Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use yarn build command in predeploy script if using yarn #4623

Merged
merged 1 commit into from
Jun 18, 2018
Merged

Use yarn build command in predeploy script if using yarn #4623

merged 1 commit into from
Jun 18, 2018

Conversation

alexbrazier
Copy link
Contributor

This PR just changes the printed output when running yarn build with a homepage set in the package.json to show yarn build instead of npm run build for the predeploy command if using yarn.

This matches the rest of the output, which also displays the yarn commands.

Changes:

    // ...
    "scripts": {
      // ...
      "predeploy": “npm run build",
      "deploy": "gh-pages -d build"
    }

To:

    // ...
    "scripts": {
      // ...
      "predeploy": “yarn build",
      "deploy": "gh-pages -d build"
    }

Tested manually to check that it is working. Screenshot below:
screenshot 2018-06-16 at 22 41 33

@facebook-github-bot
Copy link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@iansu iansu added this to the 2.0.0 milestone Jun 18, 2018
@iansu iansu merged commit f26ed0f into facebook:next Jun 18, 2018
@iansu
Copy link
Contributor

iansu commented Jun 18, 2018

Thanks!

@lock lock bot locked and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed tag: enhancement
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@alexbrazier @facebook-github-bot @iansu